Repository navigation
chore: update get transaction query params - #25
Merged
Merged
Conversation
drumwell
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This pull request enhances the transaction filtering capabilities of the
get_transactionsAPI, improves parameter validation, and updates integration and unit tests to ensure correct behavior for new and modified filters. The changes focus on allowing multi-status filtering, adding support for filtering transactions missing expense categories, and date filtering consistency. Additionally, parameter names and documentation are made more consistent.API Filtering Improvements:
statusfilter inget_transactionsnow accepts a sequence of statuses (e.g., multiple status values), and validates all provided values, raising a clear error for any invalid status. [1] [2]missing_expense_categoriesfilter, allowing users to retrieve transactions missing required expense categories. [1] [2] [3]fromDate/toDate→since/until) for consistency with api and updating integration tests to validate date range queries. [1] [2]Parameter and Documentation Consistency:
perPage,since,until, etc.) and improved docstrings to accurately describe filter options and expected types. [1] [2] [3] [4]Testing Enhancements:
receipt_missingandmissing_expense_categoriesfilters to ensure correct API parameter mapping.Version Update:
1.2.2to reflect the new features and improvements.Why do we need these changes?
Additional Notes